rabin icon indicating copy to clipboard operation
rabin copied to clipboard

Published 20 hours ago • verified publisher icon dat-ecosystem-archive

send upstream PR to rabin-cdc

Open max-mapper opened this issue 9 years ago • 3 comments

We should contribute the rabin modifications to the upstream source: https://github.com/fd0/rabin-cdc/issues/1

max-mapper avatar Jan 09 '16 20:01 max-mapper

How about first merging #4 into this project and then prepare a PR for fd0/rabin-cdc#1 ?

Also, you might want to expose the polynom to the JS API (with get/set modifiers) in case the default doesn't fit some user's use case.

green-coder avatar Jan 11 '16 01:01 green-coder

@green-coder yes that sounds good, I mentioned that here actually https://github.com/fd0/rabin-cdc/issues/1#issuecomment-170279016

max-mapper avatar Jan 11 '16 17:01 max-mapper

And then you will be able to make src/ a submodule, synchronized with rabin-cdc upstream

GamePad64 avatar Feb 20 '16 02:02 GamePad64