dash icon indicating copy to clipboard operation
dash copied to clipboard

Fix local_size() in some patterns and improve short-cut detection

Open devreal opened this issue 6 years ago • 4 comments

Fixes #653

devreal avatar Jul 10 '19 16:07 devreal

Codecov Report

Merging #655 into development will increase coverage by 0.07%. The diff coverage is 97.5%.

@@               Coverage Diff               @@
##           development     #655      +/-   ##
===============================================
+ Coverage        85.06%   85.13%   +0.07%     
===============================================
  Files              336      336              
  Lines            24954    24984      +30     
  Branches         11803    11358     -445     
===============================================
+ Hits             21226    21271      +45     
+ Misses            3693     3691       -2     
+ Partials            35       22      -13
Impacted Files Coverage Δ
dash/include/dash/pattern/BlockPattern.h 99.15% <100%> (ø) :arrow_up:
dash/test/container/MatrixTest.cc 99.35% <100%> (+0.01%) :arrow_up:
dash/include/dash/pattern/TilePattern.h 95.8% <100%> (+0.26%) :arrow_up:
dash/include/dash/pattern/BlockPattern1D.h 99.49% <100%> (ø) :arrow_up:
dash/include/dash/pattern/SeqTilePattern.h 92.77% <100%> (+0.38%) :arrow_up:
dash/include/dash/pattern/TilePattern1D.h 89.87% <85.71%> (-0.52%) :arrow_down:
...h/include/dash/iterator/internal/ContiguousRange.h 98.76% <0%> (+1.23%) :arrow_up:
dash/include/dash/Team.h 87.62% <0%> (+3.09%) :arrow_up:
... and 1 more

codecov[bot] avatar Jul 10 '19 16:07 codecov[bot]

Solves the infinite loop in #653, but not the example fully.

bertwesarg avatar Jul 11 '19 10:07 bertwesarg

Please review

devreal avatar Sep 16 '19 19:09 devreal

I'll pass. Cannot add something to this. If it works, than got ahead.

bertwesarg avatar Sep 23 '19 11:09 bertwesarg