Codecov Report

Merging #635 into development will increase coverage by <.01%. The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #635      +/-   ##
===============================================
+ Coverage        84.94%   84.95%   +<.01%     
===============================================
  Files              335      335              
  Lines            24821    24821              
  Branches         11236    11236              
===============================================
+ Hits             21085    21087       +2     
  Misses            3733     3733              
+ Partials             3        1       -2

Mar 12 '19 09:03 codecov[bot]

@pascalj this is needed to get the executor in mephisto work again:

https://github.com/mephisto-hpc/testing/commit/60f6084ca9791169eadfe3f5ddf72d7694cc021c#diff-0d729d073571dd4e46129f851327de2eR39

Mar 12 '19 10:03 bertwesarg

As a workaround for now, we could introduce dash::global_iterator_traits<GlobIterT>::memory_type, default-defined as void and specialized for ("befriended") global iterators which are actually memory-bound.

Ok, but than why did you removed @pascalj and @rkowalewski? @rkowalewski implemented the memory spaces in DASH and @pascalj implemented the mephisto part. I was only trying to get it to work again.

Mar 13 '19 07:03 bertwesarg

The changes in this PR are not related to memory spaces or Mephisto but on iterator concepts. Global memory concepts, maybe (both developed and implemented by myself, but why should that be relevant?) I did not remove them from requests for review with malicious intent.

Mar 14 '19 19:03 fuchsto