dsp-api icon indicating copy to clipboard operation
dsp-api copied to clipboard

Published 20 hours ago • verified publisher icon dasch-swiss

File not in Codecov report, even though it was changed

Open benjamingeer opened this issue 7 years ago • 1 comments

https://codecov.io/gh/dhlab-basel/Knora/pull/927?src=pr&el=tree

screen shot 2018-07-13 at 18 31 05

If I understand correctly, red means that coverage decreased. If you click on the red box at the left hand side, you see that it represents OntologyResponderV2, which was indeed changed in the PR. Codecov is right that the code that was added isn't yet used in a test. But if you click on the red box, Codecov says "File not found in report". Shouldn't it be in the report, since it's in the diagram?

benjamingeer avatar Jul 13 '18 16:07 benjamingeer

Actually I think I was wrong to say that the code that was added to OntologyResponderV2 in that PR isn't yet used in tests. It should actually be used whenever ontologies are loaded:

https://github.com/dhlab-basel/Knora/pull/927/files#diff-3fddb29c90905836a28bbacbdd8769c3

benjamingeer avatar Jul 13 '18 16:07 benjamingeer