dsp-api icon indicating copy to clipboard operation
dsp-api copied to clipboard

Published 20 hours ago • verified publisher icon dasch-swiss

refactor: Introduce ZIO HTTP (DEV-1425)

Open irinaschubert opened this issue 3 years ago • 2 comments

Issue Number: DEV-1425

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix: represents bug fixes
  • [x] Refactor: represents production code refactoring
  • [ ] Feature: represents a new feature
  • [ ] Documentation: documentation changes (no production code change)
  • [ ] Chore: maintenance tasks (no production code change)
  • [ ] Style: styles updates (no production code change)
  • [ ] Test: all about tests: adding, refactoring tests (no production code change)
  • [ ] Other... Please describe:

Does this PR introduce a breaking change?

  • [ ] Yes
  • [ ] No

Does this PR change client-test-data?

  • [ ] Yes (don't forget to update the JS-LIB team about the change)
  • [ ] No

Other information

irinaschubert avatar Oct 19 '22 10:10 irinaschubert

✅  Linked to Story DEV-1425 · DSP-API: Use ZIO HTTP
➡️  Part of Epic DEV-1380 · DSP-API: Use ZIO HTTP

swarmia[bot] avatar Oct 19 '22 10:10 swarmia[bot]

Codecov Report

Base: 86.95% // Head: 86.68% // Decreases project coverage by -0.27% :warning:

Coverage data is based on head (5cacb3f) compared to base (bfe578a). Patch coverage: 43.50% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2256      +/-   ##
==========================================
- Coverage   86.95%   86.68%   -0.28%     
==========================================
  Files         242      251       +9     
  Lines       28102    28253     +151     
==========================================
+ Hits        24435    24490      +55     
- Misses       3667     3763      +96
Impacted Files Coverage Δ
...ain/scala/dsp/project/handler/ProjectHandler.scala 100.00% <ø> (ø)
.../src/main/scala/dsp/role/handler/RoleHandler.scala 88.00% <ø> (ø)
...c/main/scala/dsp/role/repo/impl/RoleRepoLive.scala 100.00% <ø> (ø)
...shared/src/main/scala/dsp/util/UuidGenerator.scala 0.00% <0.00%> (ø)
...erface/src/main/scala/dsp/user/route/GetUser.scala 0.00% <0.00%> (ø)
...ce/src/main/scala/dsp/user/route/MigrateUser.scala 0.00% <0.00%> (ø)
...ace/src/main/scala/dsp/user/route/UserRoutes.scala 0.00% <0.00%> (ø)
...c/main/scala/dsp/user/repo/impl/UserRepoLive.scala 100.00% <ø> (ø)
webapi/src/main/scala/org/knora/webapi/Main.scala 0.00% <0.00%> (ø)
...main/scala/org/knora/webapi/config/AppConfig.scala 81.63% <ø> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 25 '22 07:10 codecov[bot]