dsp-api icon indicating copy to clipboard operation
dsp-api copied to clipboard

Published 20 hours ago • verified publisher icon dasch-swiss

refactor!: change all project IRIs to contain UUID instead of shortcode (DEV-1400)

Open mpro7 opened this issue 3 years ago • 2 comments

Issue Number: DEV-1400

Pull Request Checklist

Basic Requirements

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix: represents bug fixes
  • [x] Refactor: represents production code refactoring
  • [ ] Feature: represents a new feature
  • [ ] Documentation: documentation changes (no production code change)
  • [ ] Chore: maintenance tasks (no production code change)
  • [ ] Style: styles updates (no production code change)
  • [ ] Test: all about tests: adding, refactoring tests (no production code change)
  • [ ] Other... Please describe:

Does this PR introduce a breaking change?

  • [x] Yes
  • [ ] No

Does this PR change client-test-data?

  • [ ] Yes (don't forget to update the JS-LIB team about the change)
  • [x] No

Other information

mpro7 avatar Oct 18 '22 06:10 mpro7

✅  Linked to Story DEV-1400 · DSP-API: Fix project IRIs
➡️  Part of Epic DEV-1403 · Project UUIDs

swarmia[bot] avatar Oct 18 '22 06:10 swarmia[bot]

Codecov Report

Base: 86.85% // Head: 86.91% // Increases project coverage by +0.05% :tada:

Coverage data is based on head (1113a42) compared to base (c5c98ce). Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
+ Coverage   86.85%   86.91%   +0.05%     
==========================================
  Files         241      242       +1     
  Lines       27967    28057      +90     
==========================================
+ Hits        24292    24385      +93     
+ Misses       3675     3672       -3
Impacted Files Coverage Δ
...c/main/scala/org/knora/webapi/core/AppServer.scala 89.55% <ø> (ø)
...ages/util/search/gravsearch/GravsearchParser.scala 68.13% <0.00%> (-0.26%) :arrow_down:
...webapi/responders/admin/ProjectsResponderADM.scala 92.01% <ø> (ø)
...ora/webapi/responders/v2/OntologyResponderV2.scala 91.53% <ø> (ø)
...knora/webapi/responders/v2/SearchResponderV2.scala 90.95% <ø> (ø)
...scala/org/knora/webapi/routing/Authenticator.scala 88.88% <ø> (-0.08%) :arrow_down:
...org/knora/webapi/routing/admin/FilesRouteADM.scala 84.61% <ø> (ø)
...ebapi/store/cache/impl/CacheServiceInMemImpl.scala 100.00% <ø> (ø)
...a/webapi/store/iiif/impl/IIIFServiceSipiImpl.scala 84.76% <ø> (ø)
.../store/triplestore/TriplestoreServiceManager.scala 69.56% <ø> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 18 '22 08:10 codecov[bot]