dsp-api
dsp-api copied to clipboard
feat(sipi): add support for ODD and RNG file formats (DEV-1271)
Issue Number: DEV-1271
Pull Request Checklist
Basic Requirements
Please check if your PR fulfills the following requirements:
- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
- [ ] Bugfix: represents bug fixes
- [ ] Refactor: represents production code refactoring
- [x] Feature: represents a new feature
- [ ] Documentation: documentation changes (no production code change)
- [ ] Chore: maintenance tasks (no production code change)
- [ ] Style: styles updates (no production code change)
- [ ] Test: all about tests: adding, refactoring tests (no production code change)
- [ ] Other... Please describe:
Does this PR introduce a breaking change?
- [ ] Yes
- [x] No
Does this PR change client-test-data?
- [ ] Yes (don't forget to update the JS-LIB team about the change)
- [x] No
Other information
✅ Linked to Story DEV-1271 · DSP-API: Allow ODD and RNG file formats
Codecov Report
Patch coverage: 96.43% and project coverage change: +0.07 :tada:
Comparison is base (
1cf4727) 86.63% compared to head (2dd937c) 86.70%.
Additional details and impacted files
@@ Coverage Diff @@
## main #2197 +/- ##
==========================================
+ Coverage 86.63% 86.70% +0.07%
==========================================
Files 287 286 -1
Lines 29896 30005 +109
==========================================
+ Hits 25901 26017 +116
+ Misses 3995 3988 -7
| Impacted Files | Coverage Δ | |
|---|---|---|
| webapi/src/main/scala/org/knora/webapi/Main.scala | 0.00% <0.00%> (ø) |
|
| ...c/main/scala/org/knora/webapi/core/AppRouter.scala | 100.00% <ø> (ø) |
|
| ...la/org/knora/webapi/core/actors/RoutingActor.scala | 94.11% <ø> (-0.62%) |
:arrow_down: |
| ...SpecificGravsearchToCountPrequeryTransformer.scala | 91.66% <ø> (ø) |
|
| ...storeSpecificGravsearchToPrequeryTransformer.scala | 91.56% <ø> (ø) |
|
| ...ravsearch/types/GravsearchTypeInspectionUtil.scala | 93.82% <ø> (ø) |
|
| ...esponder/ontologymessages/OntologyMessagesV2.scala | 87.44% <ø> (+0.13%) |
:arrow_up: |
| ...ora/webapi/responders/v2/OntologyResponderV2.scala | 91.60% <ø> (-0.03%) |
:arrow_down: |
| ...slice/ontology/repo/service/OntologyRepoLive.scala | 88.23% <50.00%> (ø) |
|
| .../src/main/scala/org/knora/webapi/util/Logger.scala | 92.00% <92.00%> (ø) |
|
| ... and 20 more |
... and 2 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
DEV-1271 DSP-API: Allow ODD and RNG file formats
As a user,
I want to upload my ODD and RNG files
so I can save my work using DSP-APP.
Description
SIPI should allow the upload of files with extension ODD and RNG (Relax NG), the corresponding mime type being XML.