dsp-api icon indicating copy to clipboard operation
dsp-api copied to clipboard

Is Knora-api:hasSubListNode deliberately removed from knora-api complex?

Open tobiasschweizer opened this issue 6 years ago • 2 comments

Looking at the definition of the list node in knora-api in complex schema

{
    "@id" : "knora-api:ListNode",
    "@type" : "owl:Class",
    "rdfs:comment" : "Represents a flat or hierarchical list",
    "rdfs:subClassOf" : [ {
      "@type" : "owl:Restriction",
      "owl:maxCardinality" : 1,
      "owl:onProperty" : {
        "@id" : "knora-api:attachedToProject"
      }
    }, {
      "@type" : "owl:Restriction",
      "owl:minCardinality" : 1,
      "owl:onProperty" : {
        "@id" : "rdfs:label"
      }
    } ]
  }

we were wondering if the property hasSubListNode is deliberately excluded and if so, why.

internalPropertiesToRemove:

https://github.com/dhlab-basel/Knora/blob/2d81cd59525743cd39383555a5a2a81cb858e45e/webapi/src/main/scala/org/knora/webapi/messages/v2/responder/ontologymessages/KnoraBaseToApiV2ComplexTransformationRules.scala#L1592

tobiasschweizer avatar Aug 07 '19 15:08 tobiasschweizer

I have no memory of this. You could look for the PR in which this happened; there might be an explanation there. If it doesn’t make sense, please fix it.

benjamingeer avatar Aug 07 '19 15:08 benjamingeer

I think it was excluded in PR #775

We can look at it once you are back from your holidays, it is not urgent.

tobiasschweizer avatar Aug 08 '19 09:08 tobiasschweizer