dsp-api

dsp-api copied to clipboard

It looks like #1021 didn't work:

Also there doesn't seem to be any coverage information for this PR:

https://github.com/dhlab-basel/Knora/pull/1011

It is, but it is here: https://app.codacy.com/project/dhlab-basel/Knora/dashboard

I don't know, why this PR points to your dashboard. Maybe you could try to remove the Knora project from your personal dashboard?

It is, but it is here: https://app.codacy.com/project/dhlab-basel/Knora/dashboard

Is there something there about coverage for particular PRs? I can't find it. And when I follow the Codacy/PR Quality Review links directly from our other PRs on GitHub, I also don't find any coverage information.

Maybe you could try to remove the Knora project from your personal dashboard?

I can't find any way to do that...

Here is a description on removing a project: https://support.codacy.com/hc/en-us/articles/207994835-How-do-I-transfer-remove-a-project-from-my-account-

The options described there are “remove your project from Codacy” or “transfer your project to another of your organizations”. I guess the first option isn’t what we want. With the second option, I tried to transfer the Knora project to the dhlab-basel organisation, but it says “You need to choose at least one team.”

Yes, the first option would be the correct one.

The project is already part of the dhlab-basel team dashboard. Codacy is a bit confusing. You can add the same project to different dashboards.

or you can try to transfer it. lets see what happens ;-)

OK, I took the first option. Now I see the project under dhlab-basel, but it still doesn't have coverage information. It says "You need to request someone with write permissions to setup coverage".

Also, now I don't see a settings button anymore, so I can't change the code quality options, and Codacy is spamming my pull request with silly comments.

and Codacy is spamming my pull request with silly comments

code review ;-)

I think I turned this on yesterday. I deactivated it now. Let's see if this will lower the verbosity of codacy.

As for the coverage, sometimes it shows and sometimes it doesn't. I'm not sure why.

Let's see if this will lower the verbosity of codacy.

OK, but I still want to be able to change Codacy's settings:

• allow calling .head on a collection and .get on an Option, because this is something I do a lot in tests
• allow a method longer than 50 lines
• allow a method with more than 8 parameters

Before I "removed Knora from Codacy", I was able to change these settings. But now I don't even have a settings button to click anymore. Could this be because I don't have sufficient permissions in Codacy?

I gave you admin permissions. Now you should be able to change any settings :-)

Great, now I can add a rule that all variable names must be exactly one character long. :)

I see coverage now:

:-)

I see the coverage for the project, but I don't see it for my pull request:

https://app.codacy.com/app/dhlab-basel/Knora/pullRequest?prid=2444057

Maybe Codacy only provides coverage information for develop, not for other branches or for PRs?

Yay, we got an A from Codacy :-)