dart-vim-plugin icon indicating copy to clipboard operation
dart-vim-plugin copied to clipboard

Push to Vim repo

Open 89z opened this issue 4 years ago • 6 comments

Currently Vim is using this Dart syntax:

https://github.com/pr3d4t0r/dart-vim-syntax

which is old and has some problems. I raised the issue with the Vim developers, and they say a maintainer from this repo needs to make a pull request on the Vim repo, before any change can be made.

Would the maintainers here be interested in doing that?

89z avatar Mar 18 '21 22:03 89z

@sigmundch @cbracken - WDYT?

natebosch avatar Mar 24 '21 18:03 natebosch

Oh wow -- I had no idea that vim bundled any Dart syntax :) If we went ahead with this, would development continue here https://github.com/vim/vim/blob/master/runtime/syntax/dart.vim?

cbracken avatar Mar 30 '21 17:03 cbracken

Basically they hold a copy of your syntax here in the Vim repo.

Then if you make a change, you can make it here, but also make a PR to the Vim repo as well

89z avatar Mar 30 '21 17:03 89z

That seems reasonable to me.

cbracken avatar Mar 30 '21 17:03 cbracken

That sounds great to me too.

sigmundch avatar Mar 31 '21 03:03 sigmundch

Any update? Vim is still using the low quality dart syntax package, rather than the one here.

89z avatar Sep 18 '21 17:09 89z