Dario Castañé comments

Results 212 comments of


                                            Dario Castañé

contrib/gomodule/redigo: adds the DialURLContext method

@DataDog/apm-idm-go Please, can you review this?

[WIP] Fix race/flake with spans started/finished metrics

@hannahkm Is this PR still alive?

Lack of convenient API to start span with a parent context in v2

@Gilthoniel Thanks for reaching out! `ChildOf` was deprecated but it's still available. The way you modified your code is correct, but we agree it can bee a bit cumbersome. We'll...

Lack of convenient API to start span with a parent context in v2

@skunkworker You are right. Keep in mind that `ChildOf` is still available although marked as deprecated.

Lack of convenient API to start span with a parent context in v2

Hi @skunkworker @Gilthoniel We are thinking about this, so we want to share early feedback. We want to highlight that [`ChildOf` was deprecated](https://github.com/DataDog/dd-trace-go/pull/2397) following the rationale described in https://github.com/DataDog/dd-trace-go/issues/427. Following...

Lack of convenient API to start span with a parent context in v2

@J7mbo Not yet, but it's on the works. Please continue to use the `ChildOf` function in the meantime.

Questionable Dependency in internal/appsec/waf_test.go

Hi @bobholt, thanks for reaching out. We understand your concern about `remyoudompheng/bigfft` being potentially included in your builds. You can confirm if that package is included in the final binary...

Questionable Dependency in internal/appsec/waf_test.go

As @dolmen said, the dependency has been gone since the last releases.

ddtrace/tracer: runtime metrics v2 (exclude from release notes)

@felixge When it's planned to open the PR for review/merge?

[BUG] Fatal issue in sqlcomment.go

@fdc-michael-grosshans Thanks for reaching out. Please, can you confirm your environment details? Specially `dd-trace-go` and Go versions.