cli
cli copied to clipboard
support resources-path
Description
Signed-off-by: HueiFeng [email protected]
Issue reference
#953
Please reference the issue this PR will close: #953
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [ ] Extended the documentation
Codecov Report
Merging #1012 (e21d42e) into master (63f14c3) will decrease coverage by
0.02%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #1012 +/- ##
==========================================
- Coverage 29.18% 29.16% -0.03%
==========================================
Files 35 35
Lines 2364 2366 +2
==========================================
Hits 690 690
- Misses 1598 1599 +1
- Partials 76 77 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/standalone/run.go | 59.06% <0.00%> (-0.70%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
There needs to be some clarity on next steps before this PR is merged
- Does this PR create a local resources directory as there is for components? I believe this is needed, since this is where you can put your subscriptions and resiliency policies. See below.
| --components-path, -d | | Linux & Mac: $HOME/.dapr/components, Windows: %USERPROFILE%\.dapr\components | The path for components directory |
| --resources-path | | | The path for resources directory |
- Can I also put Components into this directory and they are loaded by the runtime?
- Does this affect Configuration YAML files? Are these treated as resources also?
- Are we going to deprecate the --components-path? If so then this needs a tracking issue as part of this PRs next steps
- Are we going to update the
dapr initto put anything into thes resources directory? - The docs need more updates than just the CLI. This is an important change and needs to be covered in other docs. I have left comments into the docs issue.
@hueifeng
Currently we are using substitution in CLI, by default using --components-path, by way of judgement in daprd binary. I want to reduce unnecessary code and replace --components-path directly with resources-path after the next two releases.
-
Can I also put Components into this directory and they are loaded by the runtime?
Now we need to specify it with the
--resources-pathparameter. -
Are we going to deprecate the
--components-path? If so then this needs a tracking issue as part of this PRs next stepsAccording to our initial plan, and the current
PRis a direct remove.
Maybe I still need to do a lot of work and maybe we can discuss what's next and whether to make big changes to the PR. What do you guys have in mind?
cc @msfussell @yaron2 @mukundansundar @pravinpushkar