nextcloud-passwords-app icon indicating copy to clipboard operation
nextcloud-passwords-app copied to clipboard

Add Single sign-on

Open fazlerabbi37 opened this issue 5 years ago • 8 comments

It would be great if you could add single sign-on as an option in addition to the traditional login. This is one of the very few android apps that is not using SSO in the Nextcloud ecosystem.

see more: https://github.com/nextcloud/Android-SingleSignOn

fazlerabbi37 avatar Mar 04 '20 16:03 fazlerabbi37

+1 i would really like this change

JonathanTreffler avatar Mar 06 '20 12:03 JonathanTreffler

Hi @fazlerabbi37, I would have to learn how to integrate native modules on react. But it is definitely the way to go. And the way to solve many "Network Error" issues. Thank you!

daper avatar Mar 09 '20 06:03 daper

Hello.

I would have to learn how to integrate native modules on react.

While hurrying to open the issue, I didn't notice that! Sorry about it. Quite a lot of android apps in Nextcloud ecosystem, mostly written in Java and Kotlin, has already implemented it. Like Talk, Notes, Deck and PhoneTrack. I am sure you would find the devs to be very helpful.

cc: @tobiasKaminsky @stefan-niedermann

fazlerabbi37 avatar Mar 09 '20 08:03 fazlerabbi37

cc: @David-Development

stefan-niedermann avatar Mar 09 '20 08:03 stefan-niedermann

Would be quite interesting to see if it works with react native out of the box. I have never used react native so please keep us updated if you encounter any issues. Were happy to help with issues regarding the sso library.

Like Talk, Notes, Deck and PhoneTrack. I am sure you would find the devs to be very helpful.

@fazlerabbi37 FYI: Nextcloud Talk is not using the SSO Library. They're using their own network stack. As far as I know they are using app passwords for that. Notes, Deck, News and PhoneTrack are indeed using the SSO Library.

David-Development avatar Mar 09 '20 17:03 David-Development

Hi! I've just did a quick test with the native library integration on the react app. It looks really promising... I was able to follow the whole flow from choosing accounts to receive a payload as a react java-script callback. So now I will have to find the proper way to include this on the app, and code it :)

daper avatar Mar 09 '20 23:03 daper

FYI: Nextcloud Talk is not using the SSO Library.

Didn't know that. I just checked and it does show up as a separate device in the web interface. Thanks for correcting me!

fazlerabbi37 avatar Mar 09 '20 23:03 fazlerabbi37

Talk needs to be separate as they need a push token, which is different to files push token. With the same token, there is no way to distinguish which app should handle a notification.

tobiasKaminsky avatar Mar 10 '20 08:03 tobiasKaminsky