laravel-vat

laravel-vat copied to clipboard

Bump ibericode/vat to ^2.0

Closes #22

@dannyvankooten do you need sth from my side to merge? Thanks for your work! :-)

@Restingo I'm afraid the PR isn't quite working yet. From a quick glance:

• The Rates class doesn't resolve right now (namespace is incorrect).
• The FacadesTest class doesn't run right now because of changed or deleted methods.
• IIRC correctly, some methods changed names so the README examples would have to be updated as well.

@Restingo I'm afraid the PR isn't quite working yet. From a quick glance:

• The Rates class doesn't resolve right now (namespace is incorrect).
• The FacadesTest class doesn't run right now because of changed or deleted methods.
• IIRC correctly, some methods changed names so the README examples would have to be updated as well.

Thanks, I will check.

@dannyvankooten do you have a hint on how to use the Facade as array like the new Countries class?

@Restingo Since the test is about making sure the Facade resolves correctly I would just pick another method on the class to test.

For example:

self::assertEquals((new Countries())->hasCountryCode('NL'), CountriesFacade::hasCountryCode('NL'));