sauron icon indicating copy to clipboard operation
sauron copied to clipboard

[Suggestion] Apply colorscheme to Sauron's windows/panels

Open tinkerng opened this issue 3 years ago • 5 comments

Is your feature request related to a problem? Please describe. Sauron's windows/panels have a white background even with dark themes/colorschemes active.

It's a small thing, users of light themes/schemes won't be affected and the others won't care much, but the contrast causes some strain after a while.

Describe the solution you'd like Having Sauron inherit the background from globally define themes or DrRacket's colorscheme.

Describe alternatives you've considered Keeping the project viewer hidden and using the terminal or the REPL for version control.

Additional context Project viewer:

sc1

Version control:

sc2

tinkerng avatar Feb 24 '22 19:02 tinkerng

This definitely would be good, I think it's related to color-prefs:register-info-based-color-schemes, the idea is if

  1. framework:basic-canvas-background
  2. framework:default-text-color

are provided, sauron will try to use it?

dannypsnl avatar Feb 24 '22 21:02 dannypsnl

or #194 will solve this problem(by throwing it to others, Jee!)

dannypsnl avatar Feb 24 '22 23:02 dannypsnl

Honestly, I don't know enough to make any good suggestions about the implementation, but seeing #194, files-viewer is a good example of what I meant, it inherits both the GTK theme (the path in the top) and DrRacket's colorscheme (the main area).

tinkerng avatar Feb 25 '22 20:02 tinkerng

Yes, and those files-viewer didn't give in few years ago are implemented now, so I think bundle it is good now

dannypsnl avatar Feb 25 '22 20:02 dannypsnl

short note: extracts color% objects from the configuration

#lang racket
(require framework)

(define-values (a-set b-set)
  (color-prefs:get-color-scheme-names))

(for/list ([color-name (in-set a-set)])
  (cons color-name
        (color-prefs:lookup-in-color-scheme
         color-name)))

dannypsnl avatar Aug 28 '22 20:08 dannypsnl