PicoW_HomeAssistant_Starter icon indicating copy to clipboard operation
PicoW_HomeAssistant_Starter copied to clipboard

[SUGGESTION] Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup()

Open JacobChrist opened this issue 2 years ago • 1 comments
trafficstars

Rename HAIntegration::configure() to either HAIntegration::begin() or HAIntegration::setup() for more orthogonal naming with the Wiring/Arduino naming conventions.

I feel like begin() better matches other Arduino classes in how its used, but because of the loop() it really feels like it should be called setup().

Frankly, configure() doesn't really bother me either, but I think begin() or setup() really hits home as to what this function is doing and where it probably should be called from.

JacobChrist avatar Nov 05 '23 18:11 JacobChrist

Yeah, thanks for thinking about this, I agree. begin() is probably the most culturally idiomatic. You've got a few thoughts brewing, want to open a PR to reflect this change?

daniloc avatar Nov 05 '23 20:11 daniloc