Daniel Wertheim

Results 27 comments of Daniel Wertheim
trafficstars

Haven't had time to look through this yet. Want to finalize 7.1 first so that it gets merged to master. Also, before doing this, a decision to revoke the `Ensure.That(...,...).Foo()`...

@dmarciano the smaller the better. Preferably one PR per feature if OK.

@ndrwrbgs what's in experimental that can't be in the public repo?

How to handle the `0` is also what got me thinking of what would be the "preferred/expected" way. @ndrwrbgs @dmarciano will it be to "expressive" to have e.g `IsNonZeroPositive`?

An enum is a lot better then a pure bool in this sense as it brings semantics. I'm guessing, most of the times, no one will use another value for...

If we don't look at the `PrivateSetterContractResolver` JSON.Net should be able to handle the above case, since it can make use of the constructor. The `PrivateSetterContractResolvers` are not made for...

And should the convention be `PropName => _propName` or ....? Not keen on just finding all private fields... as there might be cases where someone don't want private fields to...

I'm not actively using CouchDB or doing any active development with MyCouch. If you can add support for it, without breaking the existing API etc. then I don't see why...

I'll do my best to provide valid feedback

What happens to the tests if you remove: ```csharp public override void WriteNull() { base.WriteRaw(string.Empty); } ``` If nothing seem to break I'm all for getting a PR that makes...