Daniel Prilik comments

Results 129 comments of


                                            Daniel Prilik

First time using gdbstub, lldb stuck during setup

> Is there some mechanism where gdbstub logs the packets it gets Yes, this is precisely why I am suggesting you enable trace-level logging in your application :) `gdbstub` has...

First time using gdbstub, lldb stuck during setup

Given that I've definitely confirmed that lldb works with `gdbstub` in _some_ capacity (`gdbstub` already implements various lldb-specific packets that folks have upstreamed, after all), I strongly suspect you're somehow...

Supports core::error::Error for Rust 1.81+ as a bound on gdbstub::target::Target::Error

Ahh, that's right - Error is finally in core! How exciting! I would be happy to accept a PR that switches `gdbstub`'s error types over to using the `Error` type...

replace std::error::Error with core::error::Error

Good start! There are two other change you'll need to make before we can land this: - Also update [`GdbStubError`](https://docs.rs/gdbstub/latest/gdbstub/stub/struct.GdbStubError.html) to impl `core::error::Error` instead of `std::error::Error` when this feature is...

replace std::error::Error with core::error::Error

And actually, now that I think about it - do we actually need a `core::error::Error` bound on the `type Error`? I believe the downstream `Debug + Display` bounds on the...

replace std::error::Error with core::error::Error

Apologies for the delay - we just open-sourced https://github.com/microsoft/OpenVMM at $work, so my attention has been elsewhere the past few days 😅 I think a type-alias based approach is good?...

replace std::error::Error with core::error::Error

This approach looks good 👌 Two things before we can merge: 1. Address the `rustfmt` related style issue 2. Like I mentioned in https://github.com/daniel5151/gdbstub/pull/154#issuecomment-2407980989, make sure to update README.md and...

replace std::error::Error with core::error::Error

Awesome. Thanks again for sending in the PR! I'll merge this in, and cut a new gdbstub release with this new feature.

Async traits

The short answer is that, unfortunately, `gdbstub`'s current feature-level IDET traits are all sync, so unless you're willing to use `block_on`, there's no good way to call an async function...

Async traits

> It might seem simplistic, but one potential solution could be duplicating all the code handling incoming data into an asynchronous function. Yep, that's certainly an option, and one of...