elixir-git-cli icon indicating copy to clipboard operation
elixir-git-cli copied to clipboard

Published 20 hours ago • verified publisher icon danhper

Not handling repo name with a dot in it...

Open kitplummer opened this issue 5 years ago • 3 comments

iex(1)> repo = Git.clone "https://github.com/satori/go.uuid" {:ok, %Git.Repository{path: "/Users/kplummer/Code/go"}}

Seeing this in the 0.3.0 version. Gonna debug a bit, may have a PR shortly.

kitplummer avatar Nov 16 '19 16:11 kitplummer

Easy enough workaround:

iex(4)> repo = Git.clone ["https://github.com/satori/go.uuid", "go.uuid"]
{:ok, %Git.Repository{path: "/Users/kplummer/Code/lowendinsight-get/go.uuid"}}

I'm gonna move on, but maybe if you think this is a worthy issue I can probably help.

kitplummer avatar Nov 16 '19 16:11 kitplummer

This is indeed not ideal. If you could send a PR to fix this, it would be great! Thanks!

danhper avatar Nov 19 '19 13:11 danhper

@danhper - so...the challenge here is adding a test that clones a repo with a . in the name. FWICT the only way to actually test this is to clone a repo by URL. Any thoughts on this? Do you care if I add a test that clones a remote repo?

kitplummer avatar Mar 20 '20 14:03 kitplummer