danger
Running danger without write access to the repo
Currently when running danger on an open source project with a key set up to not have write access I run into
Found 2 error(s) and I don't have write access to the PR set a PR status. bundle exec danger returned exit code 1
As far as I remember we had a way to not set the return status for this situation. What's the best way to solve this? I'll submit a PR to both the setup and the docs to make this easier, just wanted to check what's your thoughts @orta :+1:
Danger should always fail if you get errors and we can't set a status, that's the point of Danger, if you don't think it's worth failing for, then use warn. Otherwise Danger only provides some text in a message somewhere.
The wording relates to https://github.com/danger/danger/issues/105 and https://github.com/danger/danger/issues/106
As far as I remember we had a way to not set the return status for this situation
This can be solved by adding a --no-fail flag to bundle exec danger - so instead of returning a fail if you have errors, it can pass.
I keep getting this error either my account is owner / admin and all the flags for the token are switched on.
Do you guys have any idea what could be the cause? PS: I am using travis-ci.
I'm running into this too. I'm using bundle exec danger --fail-on-errors=false and I still get:
Danger has failed this build.
Found 2 errors and I don't have write access to the PR to set a PR status.
Which I don't understand because the token has all repo permissions:
And it's actually able to send comments.
Hi @NachoSoto 👋
This problem happens because a user that owns Github Token (DANGER_GITHUB_API_TOKEN) has no write access to the repo itself.
You token setup is absolutely correct ✅ , but I guess you're using a CI Github user, so just invite this user to a repo:
I figured this out reading Danger's source code, there's a nice comment when this error message is thrown: https://github.com/danger/danger/blob/560733f739db3b740dba4f80b29a61a38eb9eeaf/lib/danger/request_sources/github/github.rb#L228
