notedeck
notedeck copied to clipboard
damus-io
Text wraps too late sometimes
Example of issue. Look at the center column in the before and after. In the center column the text on the right of the notes is cut off.
| before | after moving it a bit |
|---|---|
Apparently this was also an issue in gossip:
- https://github.com/emilk/egui/issues/2578 filed by @mikedilger
Fixed by @bu5hm4nn here:
- https://github.com/emilk/egui/pull/2791
Let's try this branch and see if it fixes our issues.
Yeah, there's a number of issues with horizontal_wrapped. We are currently running on "gossip-new-allpatch" branch on my fork https://github.com/bu5hm4nn/egui. You can cherry pick those patches onto 0.26 release. I already did a test with 0.27 but it needs a bit more work. (Also has some breaking changes again)
maybe it's a rounding issue: https://github.com/emilk/egui/issues/5163. In that case it would be fixed in https://github.com/emilk/egui/pull/5517, which hasn't made release yet. We could just wait for the next release and see if that fixes it
Need to try with https://github.com/emilk/egui/commit/dfcc679d5afaba3130356a2c6c922f7105f5a302 or later
I have updated gossip to use egui 0.30 and in the process updated @bu5hm4nn's patches.
The last 5 commits on this branch: https://github.com/mikedilger/egui/tree/gossip_egui_0_30
I thought I remembered you trying these patches and them not working on notedeck, but I don't see that comment in this thread. Just disregard if this isn't helpful.
@mikedilger @bu5hm4nn all of my late wrapping issues was just because I had a ui.horizontal inside of a ui.horizontal_wrapped, which seemed to negate things and also break things after it
Interesting.
I've currently got an issue where if I have a form, and a button at the bottom right-aligned, and someone types a very long value into a text field in the form, the right-aligned button at the bottom slides rightward right off the damn window and you can't see it anymore without growing the window.