epub-gen icon indicating copy to clipboard operation
epub-gen copied to clipboard

Add: timeout and retry for image download.

Open gonejack opened this issue 6 years ago • 2 comments

Signed-off-by: gonejack [email protected]

Hi, @cyrilis

I add default timeout and retry setting for image downloads for epub-gen, with SuperAgent's built-in feature.

About the tempDir, just to avoid epub-gen creates files under people's node_modules, I think it's a mistake so I change it.

image

New to coffee script but do run the test.

gonejack avatar Mar 09 '19 12:03 gonejack

SuperAgent's implementation is not good or misleading after browsing their code and discovery their code would not work as people's expectation, I would rewrite related code later.

gonejack avatar Mar 09 '19 16:03 gonejack

+1

This is a huge improvement and keeps the experience smooth saving the manual work of pre-downloading images and changing src references in html.

jenni avatar Oct 11 '19 05:10 jenni