vscode-gengetset icon indicating copy to clipboard operation
vscode-gengetset copied to clipboard

Not working without ';'

Open jrabello opened this issue 9 years ago • 2 comments

Hello,

Thanks for this amazing plug in, but it looks like it doesn't work if we declare private attributes without semicolons

private _id: string
private _date: string
private _numbers: number[]

jrabello avatar Oct 01 '16 10:10 jrabello

I think this is something up for debate (like other issues in the past where people used different formattings). It is in the end pretty though to support all kinds of codestyles in the javascript ecosystem and in this case using semicolons all the time is the more safe approach (and more natural since Typescript looks a lot like C#/Java where this is the norm) But if more people need this support I can look into it.

cybertim avatar Oct 14 '16 08:10 cybertim

I would like this support as well, looking into the regex @line24 here https://github.com/cybertim/vscode-gengetset/blob/master/src/getset.ts for possible logic to solve for this.

ugreg avatar May 19 '17 16:05 ugreg