conjur icon indicating copy to clipboard operation
conjur copied to clipboard

Implicit database dependency in credentials command classes

Open micahlee opened this issue 5 years ago • 0 comments

Two PRs ([1] [2]) for audit improvements factor out the code for password updates and API key rotation as command classes.

These command classes have an implicit dependency on the database through the Role model class. This hinders the ability to reason about the command behavior, and to test the command in isolation.

To make these command classes easier to maintain and test, this dependency should be made explicit in the dependencies.

micahlee avatar Jun 11 '20 18:06 micahlee