conjur-api-dotnet icon indicating copy to clipboard operation
conjur-api-dotnet copied to clipboard

WIP: Publsh to nuget.org

Open szh opened this issue 2 years ago • 5 comments

Desired Outcome

Add a build step to publish the .NET SDK to NuGet.

Implemented Changes

Describe how the desired outcome above has been achieved with this PR. In particular, consider:

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

Connected Issue/Story

CyberArk internal issue ID: ONYX-18165

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be merged.

Changelog

  • [ ] The CHANGELOG has been updated, or
  • [ ] This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • [ ] This PR includes new unit and integration tests to go with the code changes, or
  • [ ] The changes in this PR do not require tests

Documentation

  • [ ] Docs (e.g. READMEs) were updated in this PR
  • [ ] A follow-up issue to update official docs has been filed here: [insert issue ID]
  • [ ] This PR does not require updating any documentation

Behavior

  • [ ] This PR changes product behavior and has been reviewed by a PO, or
  • [ ] These changes are part of a larger initiative that will be reviewed later, or
  • [ ] No behavior was changed with this PR

Security

  • [ ] Security architect has reviewed the changes in this PR,
  • [ ] These changes are part of a larger initiative with a separate security review, or
  • [ ] There are no security aspects to these changes

szh avatar Mar 03 '23 14:03 szh

@LukaszStrz FYI. Not sure if Synchronizer has gotten super involved in this repo yet, but we had a Focus Friday project to push to NuGet that Shlomo picked up.

jtuttle avatar Mar 03 '23 15:03 jtuttle

Currently the thing holding this up is that there's already a version published on Nuget by a third party. @ismarc is going to work on contacting Microsoft to take ownership of the package.

szh avatar Mar 03 '23 15:03 szh

@szh Since there's no package in nuget.org, what is recommended way to reference conjur-api-dotnet in my dotnet project for Conjur Enterprise? Is the nuget package in different feed or should I download dll?

michalrosenbaum avatar Dec 03 '24 08:12 michalrosenbaum

@michalrosenbaum For now you can just download the dll from the Releases, or you can import the source code as a project reference.

szh avatar Dec 03 '24 14:12 szh

Relates to #17

szh avatar Dec 06 '24 15:12 szh