catalyst icon indicating copy to clipboard operation
catalyst copied to clipboard

SentenceDetector features extraction bug

Open gdsmiler opened this issue 4 years ago • 2 comments

Describe the bug https://github.com/curiosity-ai/catalyst/blob/cd575bfa2ce3e114a6ea03770ae440e439b283cd/Catalyst/src/Models/Base/SentenceDetector.cs#L418 In that line and next 3 used equality operator wich not implemented for IToken, so thats always false

https://github.com/curiosity-ai/catalyst/blob/cd575bfa2ce3e114a6ea03770ae440e439b283cd/Catalyst/src/Models/Base/SentenceDetector.cs#L423 Next token cannot be BOS and previous cannot be EOS when process document for sentences

gdsmiler avatar Apr 13 '22 08:04 gdsmiler

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 31 '22 07:07 stale[bot]

Still relevant

theolivenbaum avatar Jul 31 '22 20:07 theolivenbaum