mnml-ghost-theme icon indicating copy to clipboard operation
mnml-ghost-theme copied to clipboard

3rd party code should not exist in this repository.

Open derek-adair opened this issue 2 years ago • 2 comments

Generally speaking it's not a huge issue to do this; I understand the appeal of not requiring a build step for users -- being able to drop this code directly into a ghost instance lowers the bar of entry significantly. However, this generally considered bad practice for a number of reasons.

Instead, the dependencies should be linked w/ npm/yarn/whatever package management tool and the build should be served w/ a "release". Specifically, stuff like FitVids and prism.js should be removed from this repository and linked with npm.

This does add a build step, but is actually a much better experience for contributors and end users will have a succinct build history to download from. If you are interested in incorporating something like this I can submit a pull request. I plan on forking this and adding a couple bells and whistles (gulp to pre-process css/js for example).

derek-adair avatar Sep 06 '23 11:09 derek-adair

Good point @derek-adair! I tend to be a bit old-school :) A pull request would be welcome. Thanks!

curiositry avatar Sep 14 '23 01:09 curiositry

I'll gladly do such a thing.

derek-adair avatar Sep 14 '23 12:09 derek-adair