redis-oplog

redis-oplog copied to clipboard

Adds a disableMongo configuration option for disabling all the Mongo overrides, but still connecting to the Redis server, which I gather from #359 and #361 is useful for just using Vent.

I thought about naming this overrideMongo to parallel the old overridePublishFunction (and can change if desired), but given #357, I feel like it could be helpful to override Mongo even when Redis isn't being used, so felt like this was a more accurate name.

Fix #359, fix #361, and sort of relevant to #323.

@edemaine thanks. I had a test and it works perfectly!

@edemaine This is perfect timing, I was wanting to use Vent but wasn't quite ready to switch to full mongo redis-oplog. I have already done a quick test and it works great. Thanks.

I would rather use the verbose version ( "extendMongoCollection: bool") + you also have to add to the documentation about a "Vent Only Solution". the problem with this is that we have overridePublishFunction and disableMongo. Something doesn't fill uniform about this. "DisableMongo" makes me think of something bad like disabling the database all together.

@edemaine could you please finish it?

@theodorDiaconu OK, I did the suggested rename -- that is a better name. I also added a small section to docs/vent.md. Let me know if you'd like this moved somewhere else.

Keep in mind that overridePublishFunction doesn't exist anymore, as redis-oplog no longer overrides Meteor.publish in any situation (as far as I can tell).

Right, observeChanges is what is overridden now. It sends directly to the regular callbacks in Meteor's publish. My feeling is what we should have a separate package for redis-only events. This package is becoming bloated.

@ramezrafla I want to use only Vent because another features require a lot of time to refactor project. So, I’ll adopt project step by step.

@theodorDiaconu seems like @edemaine finished the work. Could you please review and merge it?

We'll have to fix the tests. To be able to merge.

I have been using this option for a couple of years now on some prod apps, its great for real-time redis data through ddp and Vent. It would be nice to get it into the next release.