Results 46 comments of Craig Tiller

@yurishkuro exactly, some kind of index based design would work. Worth noting that we want to do the map lookup once for a group of metrics at a time, but...

Does this mean we can use C++17? (asking for a friend)

This is probably not the fix we want - this will silently skip wakeups getting registered and eventually lead to a deadlock. Instead we'll need to diagnose why `Activity::current()` is...

No objections - waiting for LGTM until it gets closer to merge date.

No objections - waiting for LGTM until it gets closer to merge date.

That's unclear to me in the case of proxies: there it's probably reasonable behavior to be able to propagate unknown status codes through the stack, and provides some future proofing...