Callum Styan
Callum Styan
AFAICT, that would require a change to the `go-kit/log/term` package. So unless anyone thinks it's really necessary, I'll just leave the colors change as is for now.
current lint failure is not from my code
Good idea, PRs are welcome :)
Can you add this into the main markdown file somehow? Screenshots of what the pcap looks like or how to identify certain parts of the ADB protocol packet fields within...
I don't know for sure, sorry. If I remember correctly installing the official ADB binary would generate keys on your computer. It might just be a standard RSA/SSH key.
We also don't have any kind of query result limit parameter for the regular query APIs.
> > We also don't have any kind of query result limit parameter for the regular query APIs. > > Do I understand correctly that it's impossible to limit the...
I'm not opposed to having an interface that could swap out the underlying samples collection from remote writes perspective. Other than what Chris mentioned, we would need to clearly document...
Given that profiling is always on at the moment and we make use of it ourselves I think it might be better to default to enabled and allow disabling via...
> As for the default value, I'm surprised that there seems to be a majority of people arguing to keep it enabled by default. It seems very counter-intuitive to me...