InstantAPIs icon indicating copy to clipboard operation
InstantAPIs copied to clipboard

Remove 'Fritz' from the project, namespace, and NuGet package names

Open csharpfritz opened this issue 3 years ago • 17 comments

  • [x] Project Name renamed
  • [x] Namespace renamed
  • [ ] NuGet package renamed

csharpfritz avatar Feb 24 '22 15:02 csharpfritz

Nice little project, @csharpfritz :-)

Do you also consider renaming it to more reflect the fact that it is not about APIs per se - but more like data-driven (or CRUD?) APIs? The DB-/DbContext-centric approach implies a certain kind of use case and usage patterns when it comes to APIs - and thus should püorbably be reflected in the lib name.

ChristianWeyer avatar Feb 24 '22 15:02 ChristianWeyer

With the introduction of the JSON APIs in this preview version I published today, there are now more ways to create APIs to expose data.

I think the name "InstantAPIs" reflects what a developer wants to create: Web APIs with 1 or 2 lines of code.

csharpfritz avatar Feb 24 '22 16:02 csharpfritz

Thanks for your thoughts, Jeff.

ChristianWeyer avatar Feb 24 '22 17:02 ChristianWeyer

I appreciate the discussion and different point of view.

csharpfritz avatar Feb 24 '22 19:02 csharpfritz

I think I'll go through this rename today on stream

csharpfritz avatar Feb 26 '22 16:02 csharpfritz

Created PR #62 for this

ScottKane avatar Mar 23 '22 14:03 ScottKane

I like the name RapidAdaptiveApi meaning that while its instant also custom.

davidbuckleyni avatar Mar 23 '22 23:03 davidbuckleyni

Created PR #62 for this @ScottKane as fritz said on stream reach out first and dicuss with him u missed a comment he was going to do the rename as part of the stream. As fritz said its good etiquette to ask them first.

davidbuckleyni avatar Mar 24 '22 00:03 davidbuckleyni

@davidbuckleyni that doesn't really fit with how git works, accept the PR or don't. I did exactly what was described in the issue. Also if you notice there is a comment from 25 days ago saying the same thing about doing it on stream, yet it was still up for grabs today...

ScottKane avatar Mar 24 '22 00:03 ScottKane

Also I think you should drop the s from InstantAPIs and rename to InstantApi (gotta be pascal even though acronyms feel wrong)

ScottKane avatar Mar 24 '22 00:03 ScottKane

I am just going by what firtz said in his stream yesterday @ScottKane i think he will need to raise it again

davidbuckleyni avatar Mar 24 '22 12:03 davidbuckleyni

I watched the stream. What he said about etiquette was in regards to people creating PR's that touch way more than they should is bad etiquette. This is normal in open source so I am more that happy submitting a PR against an open issue doing exactly what it describes and nothing more.

ScottKane avatar Mar 24 '22 14:03 ScottKane

Not to mention renaming is a boring laborious task and I'm sure @csharpfritz would rather cover something more interesting.

ScottKane avatar Mar 24 '22 15:03 ScottKane

Thank you for the work on this patch, yes.. I wasn't able to get to it on stream and I'm glad to see the work to implement the change.

We need one more fix to go into the GitHub worklow to reference the new project names appropriately and then it can be merged... as well as deploy with the new NuGet name

csharpfritz avatar Apr 04 '22 18:04 csharpfritz

Should be good to go now :)

ScottKane avatar Apr 06 '22 22:04 ScottKane

Merged it... now going to rename the NuGet package

csharpfritz avatar May 17 '22 14:05 csharpfritz

@csharpfritz If I use this package now in my projetc, when you change the packages's name, my project will stop working?

rkmiecik avatar Jun 11 '22 16:06 rkmiecik