daytona icon indicating copy to clipboard operation
daytona copied to clipboard

-secret-env flag useless without -entrypoint

Open dplummer opened this issue 6 years ago • 3 comments

Is there any reason to have -entrypoint without -secret-env? Can -secret-env be removed and rolled into -entrypoint as the default behavior?

dplummer avatar Jul 02 '19 21:07 dplummer

Some use cases involve running the binary in a stand alone fashion, not inside of a container, where the endpoint flag would not be used.

broamski avatar Oct 08 '19 02:10 broamski

So if you run daytona -secret-env without -entrypoint it modifies the existing environment with the secrets?

dplummer avatar Oct 08 '19 02:10 dplummer

You're right! I think this might be a remnant from much older work that involved utilizing eval to capture outputs. Walking through this change, since it's just the removal of a boolean flag and since -entrypoint should always be also provided, this shouldn't be a breaking change?

broamski avatar Oct 08 '19 02:10 broamski