react-native-splash-screen icon indicating copy to clipboard operation
react-native-splash-screen copied to clipboard

Update README for SplashScreen.show()

Open saamerm opened this issue 3 years ago • 2 comments

  • As mentioned in #559, Updated README for the new function definition for show
SplashScreen.show(this, R.style.SplashScreenTheme, true);

saamerm avatar Feb 01 '22 16:02 saamerm

@crazycodeboy I think this will help a lot of developers

saamerm avatar Feb 11 '22 17:02 saamerm

i agree with updating the docs so explain the difference.

i just tested on a project and the only difference for me is the android navigation buttons disappears when true is passed, but is shown when false is passed. i think false looks much better so i believe that one is preferred. and before this parameter was added, it was not fullscreen.

if you set it to true, it will happen like this:

  1. user sees the navigation bar on their phone
  2. user presses your app, and the navigation buttons are hidden while splash screen is showing
  3. splash screen is hidden, navigation bar is shown again

i have a mostly white splash screen image and this is how it looks like for me.

true: true

false: false

i dont think setting fullscreen makes much sense on android, as most people will probably have the navigation buttons, as opposed to swipe navigation.

Adnan-Bacic avatar May 17 '22 12:05 Adnan-Bacic