air icon indicating copy to clipboard operation
air copied to clipboard

Fix color output on Windows

Open 8LWXpg opened this issue 2 years ago • 1 comments

Fix #128

I simply compare util_windows.go with util_unix.go, and setting c.Stdout, c.Stderr seems to have resolve this issue.

Screenshot

image

8LWXpg avatar Mar 20 '24 07:03 8LWXpg

A question for this code: Returning stdout and stderr then io.Copy seems redundant, since setting c.Stdout = os.Stdout and c.Stderr = os.Stderr basically does the same thing. Is there reason for this?

8LWXpg avatar Mar 21 '24 07:03 8LWXpg

@8LWXpg yes, the related code need to refactor 😄

cosmtrek avatar Sep 21 '24 17:09 cosmtrek