ibc-rs icon indicating copy to clipboard operation
ibc-rs copied to clipboard

[ICS03] Cover successful / failure scenarios of `verify_conn_delay_passed` with tests

Open Farhad-Shabani opened this issue 2 years ago • 1 comments

Summary

Cover different successful/failure scenarios of verify_conn_delay_passed() with tests

Proposal

Upon changes in PR #498, earlier verify_delay_passed() tests were not applicable anymore, and appropriate tests for two conditions of having connections with and without delay should be added for the related message types like recv_packet.

Farhad-Shabani avatar Mar 07 '23 19:03 Farhad-Shabani

In our current integration tests, the Connection delay_periods are set to zero. This makes this condition pass all the time.

We can make tests for this condition by setting the delay_periods non-zero.

https://github.com/cosmos/ibc-rs/blob/7ff41b3804cda649e0d7f7c21389b8d65f8d9b4b/ibc-testkit/src/relayer/utils.rs#L178-L184 https://github.com/cosmos/ibc-rs/blob/7ff41b3804cda649e0d7f7c21389b8d65f8d9b4b/ibc-testkit/src/relayer/utils.rs#L258-L273

rnbguy avatar Jul 03 '24 10:07 rnbguy