cosmos-sdk

cosmos-sdk copied to clipboard

Description

ref: #5231 Upstream from: https://github.com/iqlusioninc/cosmos-sdk/pull/2 included changes from: #9016

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.

I have...

• [ ] included the correct type prefix in the PR title
• [ ] added ! to the type prefix if API or client breaking change
• [ ] targeted the correct branch (see PR Targeting)
• [ ] provided a link to the relevant issue or specification
• [ ] followed the guidelines for building modules
• [ ] included the necessary unit and integration tests
• [ ] added a changelog entry to CHANGELOG.md
• [ ] included comments for documenting Go code
• [ ] updated the relevant documentation or specification
• [ ] reviewed "Files changed" and left comments if necessary
• [ ] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

• [ ] confirmed the correct type prefix in the PR title
• [ ] confirmed ! in the type prefix if API or client breaking change
• [ ] confirmed all author checklist items have been addressed
• [ ] reviewed state machine logic
• [ ] reviewed API design and naming
• [ ] reviewed documentation is accurate
• [ ] reviewed tests and test coverage
• [ ] manually tested (if applicable)

@atheeshp your pull request is missing a changelog!

it seems we dont handle the case when a user rotates keys then gets slashed. The evidence module will look at the active validators but the key it needs to slash may not be present anymore.

I didn't understand this completely, can you elaborate it more? BTW, we are migrating the signing-infos as well to the new rotated cons key, same as like missed blocks.

if a validator happens to misbehave at height 100, that validator swaps the key at height 101 and then the evidence is submitted in height 102 it doesnt look like the slash or evidence handle getting the swapped key. It will only see the validator doesnt exist anymore

@alexanderbez can you give another round of review?

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

converting to draft for now, we will come to it once our plate clears up thank you

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ref: #18141