compute-engine
compute-engine copied to clipboard
Draft: (partial) fix for 'ce.declare' with SymbolDefinition using prop. 'type'
Noticed that ce.declare errors when supplying a SymbolDefinition of form {type: TypeString} for second arg.
Current changes appear to address the issue, but appears to surface or reveal a few existing test errs. where throughout these, type values given through 'SymbolDefinition.type' do not conform to current type definitions: e.g. { type: 'set<integers>', ... } is given whereas in this context, according to definition of the type 'Type', a {kind: 'set', elements: 'integers' } is expected instead. Did try to investigate further but opened a bit of a can of worms.
Believe that almost all errs. can be addressed fairly easily with present changes, but may require some alterations. For reference, for the commit at which this was branched, 4 'snapshot' errors were already present split between tests 'compute-engine/compile.test.ts', and 'compute-engine/compile.test.ts'. This change surfaces ~18 newer. Feel free to edit as pleased or denounce changes