Tom C (DLS)

Results 140 comments of Tom C (DLS)

We would be very interested in this as we use apischema a lot. @tiangolo does this align with your goals for FastAPI? Would you accept a PR adding a plugin...

This is not working for me either when the 404 page is on GitHub pages. I did a bit of digging, and found that https://github.com/pydata/pydata-sphinx-theme/blob/main/src/pydata_sphinx_theme/assets/scripts/index.js#L327 is meant to install `checkPageExistsAndRedirect`...

I was going to change `mvr` to use this, but `__read_and_stash_a_motor` is sync, and would need to make it either async, or invent a new message for this. I think...

Also, I removed the doc reference to `Movable.position` as this replaces it

Unit tests failing as Ophyd seems to require a min of python3.6, looks like this is fixed in #1487

I have rebased on master, and applied the docs changes. I also allowed multiple objects to be passed to `Msg('locate')`, and it would call `obj.locate()` on them all concurrently. I...

There are only 2 unresolved conversations left here, I'd welcome comments on them. When they're resolved I think this is ready for merge

This is the best @tacaswell @danielballan @coretl and @callumforrester could come up with... ```python @dataclass class Location(Generic[T]): setpoint: T readback: T class Locatable: def get_location(self) -> SyncOrAsync[Location]: ... ```

There is a slight issue with this approach, `Locatable` is a protocol, but `Location` is a concrete class. Everywhere else in protocols we've used only protocols and typed dicts, which...

I'm on the fence between 2 and 3. Any more votes?