cordova-plugin-camera-preview

cordova-plugin-camera-preview copied to clipboard

android.hardware.Camera is deprecated. You should upgrade to android.hardware.Camera2 for API Level 21 and higher

Explained here

I'm having issues for 2 days with photos automatically rotated from portrait to landscape on samsung devices. After having tried everything i found online, I'm starting to think about developing my own version with camera2, hoping this fu*king issue will get resolved...

well I am developing for samsung devices too and i made some changes to the current master of this plugin and I corrected the image rotation. if you want to use it or fork it, go ahead its public

https://github.com/HartHerbert/cordova-plugin-camera-preview.git

thank you so much, i can't wait to see how you did it :p but i'm new to git, how to update my version with your changes ?

just install the plugin with cordova or ionic CLI cordova plugin add https://github.com/HartHerbert/cordova-plugin-camera-preview.git and use the plugin in your project. but if you currently have the other version of the plugin installed in your project, remember to uninstall it via (ionic) cordova plugin rm cordova-plugin-camera-preview. now you can use the plugin like discribed in the repos readme.

@HartHerbert We are trying to discourage forks as we previously had so many. Is there any way you can contribute some of these fixes back to this repo as PRs?

Thank you HartHerbert ! Anyone can contribute ? If i clone the project, change some files, and type "git push" on master, the remote master will be updated ? there isn't any validation from those who created the project before the change are taken into account in the remote master branch?

@jrm0695 if you clone the project, you only update your on repo, not this repo. to change the original repo you have to create a pull request from your repo to the original one.

@westonganger I am not making PR's because I'm making some big changes to the plugin (like video function and other stuff) and may the community of this plugin wont like it (like saving images on filesystem than base64)

Ya but can you not make a PR for the non file system stuff.

Has this been merged @westonganger ? I keep having issues with wrong camera orientation (I wish we could set correctOrientation:true via the camera preview plugin. so far cameraPreview has the correct Orientation but then the picture taken is rotated.

@HartHerbert Have you made any progress on the video stuff with this plugin?

@HartHerbert news with the video recording function in this plugin? I've seen this posthttps://github.com/cordova-plugin-camera-preview/cordova-plugin-camera-preview/issues/135 but I don't understand if it works and how I can implement it.