coraza icon indicating copy to clipboard operation
coraza copied to clipboard

Technical debt v3

Open jptosso opened this issue 3 years ago • 3 comments

We should try to release v3 without technical debt.

  • [ ] Move most types to the types package and sub-packages
  • [ ] Replace hardcoded strings and ints with well-documented constants
  • [ ] Custom error types
  • [ ] Add detailed documentation for each package
  • [ ] Refactor the Rule evaluation algorithm by creating a ruleEval struct
  • [ ] Reduce code complexity of modsecurity inherited transformations. For example, this is a C port to golang: https://github.com/corazawaf/coraza/blob/v2/master/transformations/url_decode_uni.go

jptosso avatar Aug 26 '22 04:08 jptosso

  • Move monolitic testdata to consumer package

jcchavezs avatar Aug 26 '22 05:08 jcchavezs

Reduce code complexity of modsecurity inherited transformations

Would you elaborate a bit more on this?

jcchavezs avatar Aug 26 '22 10:08 jcchavezs

Reduce code complexity of modsecurity inherited transformations

Would you elaborate a bit more on this?

I have quoted a sample code: https://github.com/corazawaf/coraza/blob/v2/master/transformations/url_decode_uni.go

Basically, there is C code ported to golang. We should make it the golang way

jptosso avatar Aug 31 '22 16:08 jptosso

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Oct 01 '22 04:10 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Oct 16 '22 04:10 github-actions[bot]