Luke Rodgers

Results 110 comments of Luke Rodgers

``` PHPStan detected violation(s): ------ ------------------------------------------------------------------- Line integration/framework/Magento/TestFramework/ErrorLog/Logger.php ------ ------------------------------------------------------------------- 82 Method Monolog\Logger::addRecord() invoked with 4 parameters, 2-3 required. ------ ------------------------------------------------------------------- ``` I dont know how your static tests are...

Huh thanks @zrpnr I didn't spot that was just aiming for green tests 😅

@magento run Functional Tests EE, Functional Tests CE, Functional Tests B2B

Before I spend any time fighting test cases can I please have some feedback on the official monolog stance on what Magento is doing here, see https://github.com/Seldaek/monolog/issues/1684#issuecomment-1152874168 > Your PR...

Thanks for the fyi @ihor-sviziev . I did spot this in the pre release a week or so back. In these scenarios I wonder why my commits aren't cherry picked...

Similar to this https://github.com/magento/magento2/pull/35596 which affects integration tests