kafka-tutorials

kafka-tutorials copied to clipboard

For documentation, not sure if there's any needed fix or action

The problem is that users (and Semaphore tests) don’t checkout the full project (with properties file and jar), they create the wrapper themselves. The whole value of the wrapper is diminished IMO.

by not providing the wrapper jar & properties file to users, aren’t we missing out on all the benefits of having a Gradle wrapper in the first place?

The KT has a step to create the wrapper with gradle wrapper. If the KT host upgraded from 6.7.1 to 7.0, then it will pull in the properties & jar file for 7.0

The KT then has a step ./gradlew build which is using whatever version was pulled in from gradle wrapper in the previous step (NOT what is in GitHub). My mac has 6.7.1, so when I run it locally, it works because the settings are compatible with 6.7.1. If KT host has 7.0, then it breaks.

It boils down to the fact that KTs are used for both:

• running (don’t need to run gradle wrapper)
• learning best practice (should run gradle wrapper)

Improvement suggestions welcome!