cp-helm-charts

cp-helm-charts copied to clipboard

What changes were proposed in this pull request?

This PR adds the ability to run chart-testing against the charts in this repository as discussed in #485. The tool will install the modified chart(s) in an ephemeral kubernetes environment using kind. CircleCI was chosen as the build tool (initially tried with Semaphore). This is just the first step in adopting E2E for helm.

To further this effort, the following should happen:

• This repository will need to be setup in CircleCI
• Add a templates/tests directory to each chart to perform some sort of check that the components of the chart are operating as expected. chart-testing runs a helm test after the chart installs automatically but will no-op if no tests exist. Currently, all that will be tested now is that the charts install successfully with their default values
• Should probably add a ci/test-values.yaml for each chart if we want to change default values to test in CI
• Should definitely add a build step to package/sync the charts to the Confluent helm repo

How was this patch tested?

With a CI run, however no charts have been modified yet. You can see the runs here. I have seen issues with multiple charts being tested on a single branch, but we can try doing a version bump to all charts to see if they pass and what remediations might be needed before this is merged so it does not become a blocker.

It looks like @hobbsh hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence. Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[clabot:check]

@confluentinc It looks like @hobbsh just signed our Contributor License Agreement. :+1:

Always at your service,

clabot

That's pretty awesome @hobbsh !! I will take a look at this hopefully this week (Wednesday or Thursday)

@gAmUssA anything I can do to help get this through?

@hobbsh Could you kindly redirect this PR to https://github.com/confluent-helm-charts/cp-helm-charts?

@hobbsh I moved it to https://github.com/confluent-helm-charts/cp-helm-charts/pull/7. Let's continue there. I will try to migrate it to Github actions