confluent-kafka-go

confluent-kafka-go copied to clipboard

This is just a prototype implementation of PollContext method.

ASSUMPTION: The underlying library would work with 0ms timeout if deadline is not set. If this is wrong the code needs to be adjusted.

If the underlying library cannot work without a timeout, then the code might ~~panic~~ return an error if one is not set in the context. The method will return nil if the context is cancelled or expired.

@edenhill do you want me to work on this further?

I'm a bit swamped by release work, will get back to you on this within a couple of days. Sorry for the delay.

@pavelnikolov You might don't care about this after two and a half years, but I think I implemented PollContext with cancellation in this PR: https://github.com/confluentinc/confluent-kafka-go/pull/518

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Pavel Nikolov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Wow, it's been 4 years since I opened this PR : )