dom icon indicating copy to clipboard operation
dom copied to clipboard

not using `this` context so much

Open ianstormtaylor opened this issue 11 years ago • 4 comments

i'm not a fan of relying on this inside iterators because it feels really magicky, and i think its one of the bad parts of jquery.

for some of the cases, it's already duplication, so we could easily just invoke the functions directly and let it be window like normal

for other cases, i'd propose a signature of el, i, list if we decide that el is the default people want. otherwise list, el, i if we think that list is more frequent

what do you guys think? open to suggestions, just feels really bad doing this.hasClass inside filter and such

ianstormtaylor avatar Jan 12 '14 04:01 ianstormtaylor

+1 i prefer doing list.reject(el -> el.hasClass('woot'))

yields avatar Jan 12 '14 04:01 yields

+1 this looks wired inside a iteration, and I would prefer it works like the original Array with el, i, list passed, make the el as an instance of List would be my life easier.

chemzqm avatar Jan 12 '14 08:01 chemzqm

i'm fine with this change, but is removing it and having it just be window to encourage people not to write bad code?

matthewmueller avatar Jan 18 '14 02:01 matthewmueller

yeah we've inherited a few bad things from jquery, parity is nice when it's a non-wtf thing, but I'd rather ditch the weird sides of jquery so people don't think this lib is supposed to maintain parity

tj avatar Jan 29 '14 06:01 tj