cz-cli
cz-cli copied to clipboard
commitizen
2.8.0 doesn't make any commits
With version 2.8.0 I can no longer make any commits, where it usually prints the new commit, it doesn't print anything at all. No commit is created, no error message is printed, and the exit code is still 0.
This is on OS X with zsh.
Reverting to 2.7.8 fixes the problem
same problem here, It seems that the prompt callback it isn't called.
Looks like https://github.com/commitizen/cz-cli/commit/a538dceddf829b7ca4313fe137afdf1b33587384 broke the build. The upgrade to inquirer change it's API.
In 0.12.0 inquirer the interface was
function prompt(questions: any[], callback: (answers: any) => void))
Now in 1.0.2 of inquirer the signature is
function prompt(questions: any): Promise<answers:any>
https://github.com/commitizen/cz-conventional-changelog/blob/7659b955a86a13a6ce997ce0ff9bbecf9ccc54be/index.js#L32 needs to be updated to use the new signature.
See https://github.com/commitizen/cz-conventional-changelog/pull/18 for proposed fix.
https://github.com/commitizen/cz-cli/pull/206 needs to be merged before the fix will be taken.
@LinusU This was merged and published. Are you using [email protected] and [email protected]? I just tested it in OSX and it seems to be working.
Hmm, I just had a colleague that made a clean install the other day which it didn't work for... I'll have to check Monday which versions he was using...
@albinekb Can you let me know what version of cz-conventional-changelog (or another adapter) that you are using?
I am running into the same issue.
$ npm list -g --depth=0
C:\npm
├── [email protected]
├── [email protected]
└── [email protected]
I installed [email protected] and updated my adapter and was able to commit.
I was unsuccessful when attempting to commit with:
@zacharytelschow Those adapters probably need to implement the changes in the Inquirer 1.0 API. You can see these changes here: https://github.com/commitizen/cz-conventional-changelog/commit/807b4e5d
At the end of the day we probably need to have some compatibility checking between adapters and the commitizen cli so that if you try to commit and your adapter isn't compatible with the cli you're using then you're prompted to contact the adapter author.
