FilterLists

FilterLists copied to clipboard

~~Add a flag property for if a list is directly "subscribe-able". If it is a .7z, .zip, etc., this flag will indicate that the "Subscribe" button should not be displayed.~~

~~Instead of a property, this could be something that is automated as well. (i.e., if file is a .txt vs a .zip, etc.). That would need extensive testing/debugging.~~

~~Feature overlap/similar to #7~~

~~Eventually, it could be neat to provide a subscribable mirror of these lists if the maintainer permits it.~~

~~Though this could encroach user's privacy, it could be neat to try to detect which (if any) browser extension Software the user has installed. Then, only show the "Subscribe" button for lists that are actually supported by that extension. Feedback wanted on this idea, though, if you feel that would violate user's privacy. If not, does anyone know how this could be achieved?~~

~~Updated:~~ ~~Subscribe buttons should be conditionally visible. By default, they should be visible only if they link to a .txt file (to accommodate most browser-based software tools). We could enable the button for compressed (.zip, .7z) or other formats per this if needed after #370 is implemented.~~

Updated 2:

• [x] We should hide subscribe buttons if the viewUrl is not plain-text (e.g. .7z, .zip).
• [ ] We should hide subscribe buttons if the software selected in the software filter select does not support abp:/ubo:-style subscribe links. (isAbpSubscribable)
• [ ] We should change "Subscribe" to "Import" if the software selected in the software filter select is AdGuard.

cuz AdGuard doesn't have real subscribe, it'll only import lists to user filters without possible updates. -via

• [ ] We should change abp: subscribe links to ubo: subscribe links if the list is only supported by uBO/Nano. -via
• [ ] We should support IE/TPL subscribe links. -#289
• [x] We should support Little Snitch subscribe links. -#507
• [ ] See if there is a subscribe link format that the Opera browser can support. -via

Syntax IDs 7 (uMatrix/uBlock Origin Dynamic) and maybe 10 (TPL / IE) should always hide subscribe buttons.

i read that nano adblocker is planing to support compressed lists but its not implemented yet afaik however compressed files could become subscribable for some adblockers.

yeah, that's a good point. might put an optional dropdown control that allows users to select which software they use. then, hide subscribe buttons known to not be supported by that software.

Added isAbpSubscribable to wiki.

Thanks, @DandelionSprout for updating some of these in #489 . Removing help wanted as I think that probably covers the initial set of support for abp subscribe links.

We should hide subscribe buttons if the viewUrl is not plain-text (e.g. .7z, .zip)

.tar.gz should be added to the list.

Plain text, gzip compressed may be fine (needs testing).

I actually came close to creating a pull a week ago that'd do just that for all three of those formats. But two problems got in my way.

1. Currently, if the URL for a compressed file is in ViewUrlMirror1 or ViewUrlMirror2, there would be no way to access such a link without using the F12 menu.

2. I additionally wanted to re-enable TPL subscription links so that they simply lead to https://raw.githack.com/collinbarrett/FilterLists/master/data/TPLSubscriptionAssistant.html, and in turn I wanted to give those links a light blue colour instead of dark blue. But I couldn't figure out how to add colour hex values to https://github.com/collinbarrett/FilterLists/blob/master/web/src/components/SubscribeButtons.tsx.

An alternative for №1 could be to re-colour such links orange, add a "text" value of "Download", and/or change the "message" value to "Download this list in compressed format". But that'd hinge on figuring out a solution for №2, which could then be used for this as well.