FilterLists icon indicating copy to clipboard operation
FilterLists copied to clipboard

filter Language column by lists with no language

Open collinbarrett opened this issue 7 years ago • 9 comments

Since #256 is now underway, we really need a pass at updating FilterListLanguages for all lists.

collinbarrett avatar Feb 21 '18 18:02 collinbarrett

consider comment from @elypter

There should be a way to differentiate between lists that are language indifferent and those of which the language is unknown.

Once a pass of adding languages for all current lists is complete, we could replace null/blank languages with N/A or similar in the GUI to enable filtering by language-agnostic.

collinbarrett avatar Feb 27 '18 02:02 collinbarrett

Pass at updating languages is done. Converting issue into @elypter's suggestion. Not sure the best UX and how to implement ability to filter on no languages. I can make all rows in table with no languages show something like "N/A", but I am not sure how to update the filter function (line 61ish here) to support that.

collinbarrett avatar Mar 02 '18 02:03 collinbarrett

My coding skills are not particularly extensive, but perhaps using a dash ( - ) in the language search bar to search for language-agnostic lists would be an easy and accessible option, provided that

  1. People would be aware that it'd be possible to search like that with a dash, and
  2. it'd be possible to hide the dash from the lists' Langs. bar?

DandelionSprout avatar May 15 '18 03:05 DandelionSprout

I like the dash. Before settling on a specific character, though, I'd like to get a feel for if there are any best practices or common trends used by other sites/apps. Let me know if you find examples of other sites doing something similar. Also, can you clarify what your point 2. means? What do you mean the the "Langs. bar"?

collinbarrett avatar May 15 '18 12:05 collinbarrett

Like, the column on FilterLists that says Langs. on my 9:16 portrait monitor (https://images2.imgbox.com/c3/d7/gsmySz2Y_o.png), and by "bar" I was thinking of a list's row's entry in that column.

I am unfortunately not familiar with comparable practices on other websites, when it comes to searching for non-denominational values.

DandelionSprout avatar May 15 '18 12:05 DandelionSprout

Gotchya, ok, thanks.

collinbarrett avatar May 15 '18 12:05 collinbarrett

Though, now that it's possible to just click on the Langs. button so that language-agnostic lists are show first anyway, this doesn't seem like a major issue in my eyes anymore, at least. image

DandelionSprout avatar Jul 08 '18 19:07 DandelionSprout

Now that the Languages filter is a dropdown, it'll be easy to add a filter for "None". Re-opening.

collinbarrett avatar Oct 01 '18 20:10 collinbarrett

The new UI does not yet support this. Re-opening.

collinbarrett avatar Sep 03 '19 14:09 collinbarrett