social-platform-donut-frontend icon indicating copy to clipboard operation
social-platform-donut-frontend copied to clipboard

[BUG FIX] Update the navigation panel in proposal route

Open varunks99 opened this issue 5 years ago • 4 comments

This fixes #636.

Bug description

The navigation bar on the left-hand side of the proposal related pages is not properly updated.

Root cause

The 'active' class for the navigation panel is defined by the respective props. The props passed for the proposal component was incorrect/incomplete.

Solution description

I added the state {org:true} in the ProposalEditor component and passed it as props to the navigation panel. Now when clicking on the "propose an idea button", the "Organization" tab is highlighted and active as should be.

Screenshots

Screenshot

@AuraOfDivinity @jaskiratsingh2000

varunks99 avatar Oct 01 '20 09:10 varunks99

hey @AuraOfDivinity and @ksraj123 can we review this up?

jaskiratsingh2000 avatar Oct 02 '20 17:10 jaskiratsingh2000

@AuraOfDivinity

  1. The background color of the navbar is not consistent. We still have the white color appearing over some portions. Please find the cause of this and fix it.

Are you talking about the Jitsi Meet and Logout buttons?

  1. The nav bar should take up the entire width of the navigation panel(Check and compare the implementation of this with the navbar implementation of the dashboard.)

Could you please elaborate on this a little? As I was not able to reproduce this issue.

varunks99 avatar Oct 04 '20 11:10 varunks99

image

@varunks99 Please have a look at the parts I have highlighted in red and compare it with the nav panel on the following image. They should basically look similar.

image

Notice that the nav panel takes up the entire width and the background color of the navbar is consistent.

AuraOfDivinity avatar Oct 06 '20 06:10 AuraOfDivinity

@AuraOfDivinity, I fixed it now.

Screenshot (238)

varunks99 avatar Oct 06 '20 10:10 varunks99