social-platform-donut-frontend

social-platform-donut-frontend copied to clipboard

Signed-off-by: K mehant [email protected]

Todo list:

• [X] container config for publishing
• [X] container config for local development
• [x] GitHub workflow for build and push container image
• [X] docker-compose file to set up the complete project instantly (docker-compose up command)
• [x] Create docker hub account for Codeuino Donut
• [x] Add GitHub secrets DOCKER_USERNAME and DOCKER_PASSWORD to this repository
• [x] Write docs for developers to make use of development docker file

Deploy preview for donut-frontend failed.

Built with commit f67e3cbede335cc90e69eb630f3ee1c79bd001b8

https://app.netlify.com/sites/donut-frontend/deploys/5f07415aaa833e000876b193

Please attach readme link here

https://docs.codeuino.org/donut-social-networking-platform/installations/installation-using-docker

@vaibhavdaren Please let me know any other tests we can write or have to for docker files (PS: I am not sure of any other than using a linter) other than testing locally or within the Actions pipeline by building the image.

I means that we need to test locally before merging the pr. Thats it.

@vaibhavdaren Please don't merge, I need to fix the pipeline a bit 😅

Please ask @jaskiratsingh2000 to run locally and merge.

Please ask @jaskiratsingh2000 to run locally and merge.

@vaibhavdaren I made the fix, actually, we had the same problem with the backend so I fixed that. Now the pipeline should work. Please put your review again. Thank you.

@jaskiratsingh2000 Can you please review this by locally running this feature, I have done it from my side anyways.

I would be able to do probably by wednesday. @devesh-verma will respond soon

Hi, @kmehant After struggling so much with my docker desktop and testing it threw an error for me. I have 2 major concerns:

• The information you have provided here seems to be very vague as if the command " $ docker-compose -f docker-compose.dev.yml up --build " needs to be entered then what and how one should go about it is missing from your documentation. You have not mentioned where to write too. So from the non-technical point of view, it becomes difficult to test.
• On running the above following command it shows me an error of "command not found"

Thanks

@jaskiratsingh2000 FYI -

• Docker is a DevOps tool so installing, maintaining and using will be little difficult for non-technical or completely frontend devs. I also agree that it is not just installing, using and maintaining it on your machine is also important as it a Daemon process itself with os level virtualization involved. So clearing up volumes, large images running containers, cached containers and many more which use lots of system resources. So I admit it's not a easy process to follow. That does not mean that our documentation should educate people about DevOps, container and Docker tool.

• Does the community include DevOps people? I would request you to give this testing responsibility to a DevOps guy.

Answering your concerns: Commands are usually meant to go to a terminal, also please notice $ sign which means it should go to your terminal on Mac or Linux and git bash on Windows. I assume every dev guy would know about terminal and commands which is similar to running npm install as mentioned in DONUT docs. **Command not found ** means docker-compose command is not present on your machine, you might have not installed docker machine properly or you might typed the wrong command I guess you might have added $

Any more concerns please let me know.
Thank you.